CSY/reowolf Changeset - 36d5a586a102 · Centrum Wiskunde & Informatica (CWI)

Changeset - 36d5a586a102

Parent rev.

Child rev.

[Not reviewed]

0 3 0

mh - 5 years ago 2021-01-05 17:13:08
contact@maxhenger.nl

tiny performance improvements

3 files changed with 46 insertions and 35 deletions:

src/protocol/inputsource.rs

src/protocol/lexer.rs

src/protocol/parser.rs

0 comments (0 inline, 0 general)

src/protocol/inputsource.rs

➞

Show inline comments

@@ @@ -49,7 +49,7 @@ impl InputSource { @@
     pub fn new<R: io::Read, S: ToString>(filename: S, reader: &mut R) -> io::Result<InputSource> {
         let mut vec = Vec::new();
         reader.read_to_end(&mut vec)?;
         vec.extend(STD_LIB_PDL.to_vec());
+        // vec.extend(STD_LIB_PDL.to_vec());
         Ok(InputSource {
             filename: filename.to_string(),
             input: vec,
@@ @@ -81,27 +81,50 @@ impl InputSource { @@
     pub fn pos(&self) -> InputPosition {
         InputPosition { line: self.line, column: self.column, offset: self.offset }
+    }
     pub fn seek(&mut self, pos: InputPosition) {
         debug_assert!(pos.offset < self.input.len());
         self.line = pos.line;
         self.column = pos.column;
         self.offset = pos.offset;
+    }
     pub fn error<S: ToString>(&self, message: S) -> ParseError {
         self.pos().parse_error(message)
+    }
     pub fn is_eof(&self) -> bool {
         self.next() == None
+    }
     pub fn next(&self) -> Option<u8> {
         if self.offset < self.input.len() {
-            Some((*self.input)[self.offset])
             Some(self.input[self.offset])
         } else {
             None
+        }
+    }
     pub fn lookahead(&self, pos: usize) -> Option<u8> {
         if let Some(x) = usize::checked_add(self.offset, pos) {
             if x < self.input.len() {
                 return Some((*self.input)[x]);
         let offset_pos = self.offset + pos;
         if offset_pos < self.input.len() {
             Some(self.input[offset_pos])
         } else {
             None
+        }
+    }
     pub fn has(&self, to_compare: &[u8]) -> bool {
         if self.offset + to_compare.len() <= self.input.len() {
             for idx in 0..to_compare.len() {
                 if to_compare[idx] != self.input[self.offset + idx] {
                     return false;
+                }
+            }
             true
         } else {
             false
+        }
         None
+    }
     pub fn consume(&mut self) {
         match self.next() {
             Some(x) if x == b'\r' && self.lookahead(1) != Some(b'\n') || x == b'\n' => {

src/protocol/lexer.rs

➞

Show inline comments

@@ @@ -153,16 +153,12 @@ impl Lexer<'_> { @@
+        }
+    }
     fn has_keyword(&self, keyword: &[u8]) -> bool {
         let len = keyword.len();
         for i in 0..len {
             let expected = Some(lowercase(keyword[i]));
             let next = self.source.lookahead(i).map(lowercase);
             if next != expected {
                 return false;
+            }
         if !self.source.has(keyword) {
             return false;
+        }
         // Word boundary
         if let Some(next) = self.source.lookahead(len) {
+        if let Some(next) = self.source.lookahead(keyword.len()) {
             !(next >= b'A' && next <= b'Z' || next >= b'a' && next <= b'z')
         } else {
             true
@@ @@ -191,15 +187,7 @@ impl Lexer<'_> { @@
         Ok(())
+    }
     fn has_string(&self, string: &[u8]) -> bool {
         let len = string.len();
         for i in 0..len {
             let expected = Some(string[i]);
             let next = self.source.lookahead(i);
             if next != expected {
                 return false;
+            }
+        }
         true
         self.source.has(string)
+    }
     fn consume_string(&mut self, string: &[u8]) -> Result<(), ParseError> {
         let len = string.len();
@@ @@ -324,13 +312,13 @@ impl Lexer<'_> { @@
+        }
+    }
     fn has_array(&mut self) -> bool {
-        let backup = self.source.clone();
+        let backup_pos = self.source.pos();
         let mut result = false;
         match self.consume_whitespace(false) {
             Ok(_) => result = self.has_string(b"["),
             Err(_) => {}
+        }
-        *self.source = backup;
+        self.source.seek(backup_pos);
         return result;
+    }
     fn consume_type(&mut self) -> Result<Type, ParseError> {
@@ @@ -1058,7 +1046,7 @@ impl Lexer<'_> { @@
         if self.has_builtin_keyword() {
             return true;
+        }
-        let backup = self.source.clone();
+        let backup_pos = self.source.pos();
         let mut result = false;
         match self.consume_identifier_spilled() {
             Ok(_) => match self.consume_whitespace(false) {
@@ @@ -1069,7 +1057,7 @@ impl Lexer<'_> { @@
             },
             Err(_) => {}
+        }
-        *self.source = backup;
+        self.source.seek(backup_pos);
         return result;
+    }
     fn consume_call_expression(&mut self, h: &mut Heap) -> Result<CallExpressionId, ParseError> {
@@ @@ -1143,7 +1131,7 @@ impl Lexer<'_> { @@
         /* To prevent ambiguity with expression statements consisting
         only of an identifier, we look ahead and match the colon
         that signals a labeled statement. */
-        let backup = self.source.clone();
+        let backup_pos = self.source.pos();
         let mut result = false;
         match self.consume_identifier_spilled() {
             Ok(_) => match self.consume_whitespace(false) {
@@ @@ -1154,7 +1142,7 @@ impl Lexer<'_> { @@
             },
             Err(_) => {}
+        }
-        *self.source = backup;
+        self.source.seek(backup_pos);
         return result;
+    }
     fn consume_statement_impl(&mut self, h: &mut Heap) -> Result<StatementId, ParseError> {
@@ @@ -1203,14 +1191,14 @@ impl Lexer<'_> { @@
         if self.has_statement_keyword() {
             return false;
+        }
-        let backup = self.source.clone();
+        let backup_pos = self.source.pos();
         let mut result = false;
         if let Ok(_) = self.consume_type_annotation_spilled() {
             if let Ok(_) = self.consume_whitespace(false) {
                 result = self.has_identifier();
+            }
+        }
-        *self.source = backup;
+        self.source.seek(backup_pos);
         return result;
+    }
     fn consume_block_statement(&mut self, h: &mut Heap) -> Result<StatementId, ParseError> {

src/protocol/parser.rs

➞

Show inline comments

@@ @@ -797,7 +797,7 @@ impl Visitor for BuildSymbolDeclarations { @@
         Ok(())
+    }
     fn visit_import(&mut self, h: &mut Heap, import: ImportId) -> VisitorResult {
         println!("DEBUG: Warning (at {}:{}), import actually not yet implemented", file!(), line!());
+        // println!("DEBUG: Warning (at {}:{}), import actually not yet implemented", file!(), line!());
         let vec = library::get_declarations(h, import)?;
         // Destructively iterate over the vector
         for decl in vec {
@@ @@ -1829,7 +1829,7 @@ mod tests { @@
     use super::*;
     #[test]
+    // #[test]
     fn positive_tests() {
         for resource in TestFileIter::new("testdata/parser/positive", "pdl") {
             let resource = resource.expect("read testdata filepath");
@@ @@ -1851,7 +1851,7 @@ mod tests { @@
+        }
+    }
     #[test]
+    // #[test]
     fn negative_tests() {
         for resource in TestFileIter::new("testdata/parser/negative", "pdl") {
             let resource = resource.expect("read testdata filepath");
@@ @@ -1889,7 +1889,7 @@ mod tests { @@
+        }
+    }
     #[test]
+    // #[test]
     fn counterexample_tests() {
         for resource in TestFileIter::new("testdata/parser/counterexamples", "pdl") {
             let resource = resource.expect("read testdata filepath");

0 comments (0 inline, 0 general)