CSY/reowolf Changeset - e7e7211531c8 · Centrum Wiskunde & Informatica (CWI)

Changeset - e7e7211531c8

Parent rev.

Child rev.

[Not reviewed]

0 5 1

mh - 3 years ago 2022-04-21 08:50:30
contact@maxhenger.nl

Initial error-handling tests

6 files changed with 43 insertions and 4 deletions:

docs/runtime/sync.md

src/runtime2/component/component.rs

src/runtime2/component/component_internet.rs

src/runtime2/component/component_pdl.rs

src/runtime2/tests/error_handling.rs

src/runtime2/tests/mod.rs

0 comments (0 inline, 0 general)

docs/runtime/sync.md

➞

Show inline comments

 So that is to say that this `ClosePort(sync)` causes instant failure of `C` if it has used the closed port in a round without consensus, or if it uses that port in the future. Note that this `ClosePort(sync)` system causes cascading failures throughout the disjoint synchronous regions. This is as intended: once one component's PDL program can no longer be executed, we cannot depend on the discovery of all the peers that constitute the intended synchronous region. So instead we rely on a peer-to-peer mechanism to make sure that every component is notified of failure.
 However, while these cascading peer-to-peer `ClosePort(sync)` messages are happily shared around, we still have a leader component somewhere, and components that have not yet been notified of the failure. Here we can make several design choices to
@@ \ No newline at end of file @@
 However, while these cascading peer-to-peer `ClosePort(sync)` messages are happily shared around, we still have a leader component somewhere, and components that have not yet been notified of the failure.
@@ \ No newline at end of file @@

src/runtime2/component/component.rs

➞

Show inline comments

@@ @@ -425,6 +425,7 @@ pub(crate) fn default_handle_control_message( @@
                 // that if we have a successful sync round, followed by the peer
                 // closing the port, that we don't consider the sync round to
                 // have failed by mistake.
                 let error_due_to_port_use =
                 if content.closed_in_sync_round && exec_state.mode.is_in_sync_block() && port_was_used {
                     return Err((
                         last_instruction,

src/runtime2/component/component_internet.rs

➞

Show inline comments

@@ @@ -207,6 +207,8 @@ impl Component for ComponentTcpClient { @@
                                 return CompScheduling::Sleep;
+                            }
                         } else {
                             let port_handle = comp_ctx.get_port_handle(self.pdl_input_port_id);
                             comp_ctx.get_port_mut(port_handle).last_instruction = PortInstruction::NoSource;
                             self.exec_state.set_as_blocked_get(self.pdl_input_port_id);
                             return CompScheduling::Sleep;
+                        }

src/runtime2/component/component_pdl.rs

➞

Show inline comments

@@ @@ -318,6 +318,8 @@ impl Component for CompPDL { @@
                 let port_id = port_id_from_eval(port_id);
                 let port_handle = comp_ctx.get_port_handle(port_id);
                 comp_ctx.get_port_mut(port_handle).last_instruction = PortInstruction::SourceLocation(expr_id);
                 let port_index = comp_ctx.get_port_index(port_handle);
                 if let Some(message) = &self.inbox_main[port_index] {
                     // Check if we can actually receive the message
@@ @@ -578,7 +580,7 @@ impl CompPDL { @@
+            }
         };
-        self.handle_component_error(sched_Ctx, error);
+        self.handle_component_error(sched_ctx, error);
+    }
     fn handle_component_error(&mut self, sched_ctx: &SchedulerCtx, error: CompError) {

src/runtime2/tests/error_handling.rs

➞

Show inline comments

@@ new file 100644 @@
 use super::*;
 #[test]
 fn test_unconnected_component_error() {
     let pd = ProtocolDescription::parse(b"
     primitive interact_with_noone() {
         u8[] array = { 5 };
         auto value = array[1];
+    }
     ").unwrap();
     let rt = Runtime::new(1, true, pd).unwrap();
     create_component(&rt, "", "interact_with_noone", no_args());
+}
 #[test]
 fn test_connected_uncommunicating_component_error() {
     let pd = ProtocolDescription::parse(b"
     primitive crashing_and_burning(out<u32> unused) {
         u8[] array = { 1337 };
         auto value = array[1337];
+    }
     primitive sitting_idly_waiting(in<u32> never_providing) {
         sync auto a = get(never_providing);
+    }
     composite constructor() {
         channel a -> b;
         new sitting_idly_waiting(b);
         new crashing_and_burning(a);
     }").unwrap();
     let rt = Runtime::new(1, true, pd).unwrap();
     create_component(&rt, "", "constructor", no_args());
+}
@@ \ No newline at end of file @@

src/runtime2/tests/mod.rs

➞

Show inline comments

@@ @@ -3,7 +3,9 @@ use crate::protocol::eval::*; @@
 use crate::runtime2::runtime::*;
 use crate::runtime2::component::{CompCtx, CompPDL};
 fn create_component(rt: &Runtime, module_name: &str, routine_name: &str, args: ValueGroup) {
 mod error_handling;
 pub(crate) fn create_component(rt: &Runtime, module_name: &str, routine_name: &str, args: ValueGroup) {
     let prompt = rt.inner.protocol.new_component(
         module_name.as_bytes(), routine_name.as_bytes(), args
     ).expect("create prompt");
     rt.inner.enqueue_work(key);
+}
 fn no_args() -> ValueGroup { ValueGroup::new_stack(Vec::new()) }
+pub(crate) fn no_args() -> ValueGroup { ValueGroup::new_stack(Vec::new()) }
 #[test]
 fn test_component_creation() {

0 comments (0 inline, 0 general)