EI/VirtualLeaf Changeset - 6bcb69712a0e · Centrum Wiskunde & Informatica (CWI)

Parent rev.

Child rev.

[Not reviewed]

default

0 9 2

Roeland Merks - 15 years ago 2010-11-24 18:02:13
roeland.merks@cwi.nl

In response to referee's comment:

"However, (although it is probably not important for model developers), I was
still unable to load the model ‘Meinhardt 1976 with growth’ example from the
‘Models’ drop down menu, I got the ‘Fatal error’ message ‘stepwise underflow in

rkqs, with h=0.000000 and htry = 0.100000’. The model did work when I selected
the Meinhardt model in both the Models and the File -> Read leaf menus together,
it would be preferable if the models loaded from the Models menu worked

automatically. I am not sure that the update referred to in the author’s
response permits the loading of ‘My First Model in Virtual Leaf’ from the
‘Models’ drop down menu; I only got a cell that wiggled."

I made the following changes:

- meinhardt_plugin now reads "meinhardt_init.xml" by default
- changed the name of 'My First Model in Virtual Leaf’ to '0: Empty model template (does nothing)' to make it clear that the wiggle cell is the intended behavior for this model example.
- Added default parameter files for Tutorial1A-D and Tutorial2 to prevent variable behavior depending on the last parameter settings used.

--
user: Roeland Merks <roeland.merks@cwi.nl>
branch 'default'
added data/leaves/tutorial1_init.xml
added data/leaves/tutorial2_init.xml
changed data/leaves/auxin_growth.xml
changed data/leaves/meinhardt_init.xml
changed src/TutorialCode/Tutorial0/tutorial0.cpp
changed src/TutorialCode/Tutorial1A/tutorial1A.h
changed src/TutorialCode/Tutorial1B/tutorial1B.h
changed src/TutorialCode/Tutorial1C/tutorial1C.h
changed src/TutorialCode/Tutorial1D/tutorial1D.h
changed src/TutorialCode/Tutorial2/tutorial2.h
changed src/build_models/meinhardtplugin.h

11 files changed with 14 insertions and 1 deletions:

data/leaves/auxin_growth.xml

bin+mod

data/leaves/meinhardt_init.xml

bin+mod

data/leaves/tutorial1_init.xml

bin+new file

data/leaves/tutorial2_init.xml

bin+new file

src/TutorialCode/Tutorial0/tutorial0.cpp

src/TutorialCode/Tutorial1A/tutorial1A.h

src/TutorialCode/Tutorial1B/tutorial1B.h

src/TutorialCode/Tutorial1C/tutorial1C.h

src/TutorialCode/Tutorial1D/tutorial1D.h

src/TutorialCode/Tutorial2/tutorial2.h

src/build_models/meinhardtplugin.h

0 comments (0 inline, 0 general)

data/leaves/auxin_growth.xml

➞

Show inline comments

binary diff not shown

data/leaves/meinhardt_init.xml

➞

Show inline comments

binary diff not shown

data/leaves/tutorial1_init.xml

➞

Show inline comments

		new file 100644
		binary diff not shown

data/leaves/tutorial2_init.xml

➞

Show inline comments

		new file 100644
		binary diff not shown

src/TutorialCode/Tutorial0/tutorial0.cpp

➞

Show inline comments

@@ @@ -34,7 +34,7 @@ static const std::string _module_id("$Id @@
 QString Tutorial0::ModelID(void) {
   // specify the name of your model here
-  return QString( "My first model in VirtualLeaf" );
+  return QString( "0: Empty model template (does nothing)" );
+}
 // return the number of chemicals your model uses

src/TutorialCode/Tutorial1A/tutorial1A.h

➞

Show inline comments

@@ @@ -53,6 +53,9 @@ public: @@
 	virtual void SetCellColor(CellBase *c, QColor *color);
 	// return number of chemicals
 	virtual int NChem(void);
 	virtual QString DefaultLeafML(void) { return QString("tutorial1_init.xml"); }
 };

src/TutorialCode/Tutorial1B/tutorial1B.h

➞

Show inline comments

@@ @@ -53,6 +53,8 @@ public: @@
 	virtual void SetCellColor(CellBase *c, QColor *color);
 	// return number of chemicals
 	virtual int NChem(void);
 	virtual QString DefaultLeafML(void) { return QString("tutorial1_init.xml"); }
 };

src/TutorialCode/Tutorial1C/tutorial1C.h

➞

Show inline comments

@@ @@ -53,6 +53,7 @@ public: @@
 	virtual void SetCellColor(CellBase *c, QColor *color);
 	// return number of chemicals
 	virtual int NChem(void);
 	virtual QString DefaultLeafML(void) { return QString("tutorial1_init.xml"); }
 };

src/TutorialCode/Tutorial1D/tutorial1D.h

➞

Show inline comments

@@ @@ -53,6 +53,7 @@ public: @@
 	virtual void SetCellColor(CellBase *c, QColor *color);
 	// return number of chemicals
 	virtual int NChem(void);
 	virtual QString DefaultLeafML(void) { return QString("tutorial1_init.xml"); }
 };

src/TutorialCode/Tutorial2/tutorial2.h

➞

Show inline comments

@@ @@ -53,6 +53,9 @@ public: @@
 	virtual void SetCellColor(CellBase *c, QColor *color);
 	// return number of chemicals
 	virtual int NChem(void);
 	// default XML file to be loaded on startup
 	virtual QString DefaultLeafML(void) { return QString("tutorial2_init.xml"); }
 };

src/build_models/meinhardtplugin.h

➞

Show inline comments

@@ @@ -55,6 +55,9 @@ class MeinhardtPlugin : public QObject, @@
   virtual void SetCellColor(CellBase *c, QColor *color);
   // return number of chemicals
   virtual int NChem(void) { return 4; }
   // default XML file to be loaded on startup
   virtual QString DefaultLeafML(void) { return QString("meinhardt_init.xml"); }
 };
 #endif

0 comments (0 inline, 0 general)